2019-12-30 23:12:17 +00:00
|
|
|
This document explains why [tview](https://github.com/rivo/tview) was forked to
|
2020-02-20 17:48:15 +00:00
|
|
|
create [cview](https://gitlab.com/tslocum/cview). It also explains any
|
|
|
|
|
differences between the projects and tracks which tview pull requests have been
|
|
|
|
|
merged into cview.
|
2019-12-30 23:12:17 +00:00
|
|
|
|
|
|
|
|
# Why fork?
|
|
|
|
|
|
|
|
|
|
[rivo](https://github.com/rivo), the creator and sole maintainer of tview,
|
2020-02-16 18:12:55 +00:00
|
|
|
explains his reviewing and merging process in a [GitHub comment](https://github.com/rivo/tview/pull/298#issuecomment-559373851).
|
2019-12-30 23:12:17 +00:00
|
|
|
|
|
|
|
|
He states that he does not have the necessary time or interest to review,
|
|
|
|
|
discuss and merge pull requests:
|
|
|
|
|
|
|
|
|
|
>this project is quite low in priority. It doesn't generate any income for me
|
|
|
|
|
>and, unfortunately, reviewing issues and PRs is also not much "fun".
|
|
|
|
|
|
|
|
|
|
>But some other people submitted large PRs which will cost me many hours to
|
|
|
|
|
>review. (I had to chuckle a bit when I saw [this comment](https://github.com/rivo/tview/pull/363#issuecomment-555484734).)
|
|
|
|
|
|
|
|
|
|
>Lastly, I'm the one who ends up maintaining this code. I have to be 100%
|
|
|
|
|
>behind it, understand it 100%, and be able to make changes to it later if
|
|
|
|
|
> necessary.
|
|
|
|
|
|
|
|
|
|
cview aims to solve these issues by increasing the number of project
|
|
|
|
|
maintainers and allowing code changes which may be outside of tview's scope.
|
|
|
|
|
|
2020-02-20 17:48:15 +00:00
|
|
|
# Differences
|
|
|
|
|
|
|
|
|
|
## QueueUpdate and QueueUpdateDraw do not block
|
|
|
|
|
|
|
|
|
|
tview [blocks until the queued function returns](https://github.com/rivo/tview/blob/fe3052019536251fd145835dbaa225b33b7d3088/application.go#L510).
|
|
|
|
|
|
2019-12-30 23:12:17 +00:00
|
|
|
# Merged pull requests
|
|
|
|
|
|
2020-01-01 16:00:22 +00:00
|
|
|
The following tview pull requests have been merged into cview:
|
|
|
|
|
|
|
|
|
|
- [#378 Throttle resize handling](https://github.com/rivo/tview/pull/378)
|
2020-01-05 17:41:15 +00:00
|
|
|
- [#368 Add support for displaying text next to a checkbox](https://github.com/rivo/tview/pull/368)
|
2020-01-02 04:57:16 +00:00
|
|
|
- [#363 Mouse support](https://github.com/rivo/tview/pull/363)
|
2020-01-01 16:00:22 +00:00
|
|
|
- [#353 Add window size change handler](https://github.com/rivo/tview/pull/353)
|
2020-01-02 03:43:18 +00:00
|
|
|
- [#347 Handle ANSI code 39 and 49](https://github.com/rivo/tview/pull/347)
|
2020-01-05 17:14:15 +00:00
|
|
|
- [#336 Don't skip regions at end of line](https://github.com/rivo/tview/pull/336)
|
2020-01-02 03:43:18 +00:00
|
|
|
- [#296 Fixed TextView's reset [-] setting the wrong color](https://github.com/rivo/tview/pull/296)
|
