tslocum
/
cview
2
4
Fork 4
Code Issues 22 Pull Requests 1 Releases Activity
Labels Milestones
New Issue

Feature: Support strikethrough formatting #17

Closed
opened 2 years ago by makeworld-the-better-one · 5 comments
makeworld-the-better-one commented 2 years ago (Migrated from gitlab.com)
Owner

See this question for some escape codes. It'd be nice to have this available as a tag as well.

See [this question](https://askubuntu.com/questions/528928/how-to-do-underline-bold-italic-strikethrough-color-background-and-size-i) for some escape codes. It'd be nice to have this available as a tag as well.
tslocum commented 2 years ago (Migrated from gitlab.com)
Owner

tcell has not yet implemented support for strikethrough. Please help push towards implementing it upstream and it will also be supported in cview by commenting or, if possible, opening a pull request on tcell.

I've implemented support for italic flags just now.

tcell has [not yet implemented support for strikethrough](https://github.com/gdamore/tcell/issues/256). Please help push towards implementing it upstream and it will also be supported in cview by commenting or, if possible, opening a pull request on tcell. I've [implemented support for italic flags](https://gitlab.com/tslocum/cview/-/commit/1d976945dcca30b0105b955bd0bb8414a1629214) just now.
tslocum commented 2 years ago (Migrated from gitlab.com)
Owner

changed title from Feature: Support {-italics and strikethrough-} to Feature: Support {+strikethrough formatting+}

changed title from **Feature: Support {-italics and strikethrough-}** to **Feature: Support {+strikethrough formatting+}**
makeworld-the-better-one commented 2 years ago (Migrated from gitlab.com)
Owner

Thanks!

Thanks!
nahojkap commented 2 years ago (Migrated from gitlab.com)
Owner

@tslocum While you added strikethrough handling in the overlayStyle in utils.go as part of your commit, I think you might have forgotten to update the colorPattern regexp? The [::s] pattern is not recognized unfortunately.

@tslocum While you added strikethrough handling in the overlayStyle in utils.go as part of your commit, I think you might have forgotten to update the `colorPattern` regexp? The [::s] pattern is not recognized unfortunately.
tslocum commented 2 years ago (Migrated from gitlab.com)
Owner

Thanks @nahojkap. I have updated the pattern.

Thanks @nahojkap. I have updated the pattern.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
tablepad
textarea
wordwrap
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes