Switch to sync.RWMutex globally #30

New Issue

2020-07-08T03:48:44Z

makeworld-the-better-one commented

2020-07-08 03:48:44 +00:00

(Migrated from gitlab.com)

I've noticed pretty much of all of the library functions use a sync.Mutex to ensure safe concurrency, which is great. But I was thinking that using sync.RWMutex would be better in all cases, since the mutex is invoked even when simply getting/reading a variable. Using sync.RWMutex and changing relevant lines to RLock and RUnlock would make the code more efficient.

I've noticed pretty much of all of the library functions use a `sync.Mutex` to ensure safe concurrency, which is great. But I was thinking that using `sync.RWMutex` would be better in all cases, since the mutex is invoked even when simply getting/reading a variable. Using `sync.RWMutex` and changing relevant lines to `RLock` and `RUnlock` would make the code more efficient.

makeworld-the-better-one commented

2020-08-02 17:34:13 +00:00

(Migrated from gitlab.com)

Thanks!

Sign in to join this conversation.