tslocum
/
cview
2
4
Fork 4
Code Issues 17 Pull Requests 1 Releases Activity
Labels Milestones
New Issue

Switch to sync.RWMutex globally #30

Closed
opened 2 years ago by makeworld-the-better-one · 1 comments
makeworld-the-better-one commented 2 years ago (Migrated from gitlab.com)
Owner

I've noticed pretty much of all of the library functions use a sync.Mutex to ensure safe concurrency, which is great. But I was thinking that using sync.RWMutex would be better in all cases, since the mutex is invoked even when simply getting/reading a variable. Using sync.RWMutex and changing relevant lines to RLock and RUnlock would make the code more efficient.

I've noticed pretty much of all of the library functions use a `sync.Mutex` to ensure safe concurrency, which is great. But I was thinking that using `sync.RWMutex` would be better in all cases, since the mutex is invoked even when simply getting/reading a variable. Using `sync.RWMutex` and changing relevant lines to `RLock` and `RUnlock` would make the code more efficient.
makeworld-the-better-one commented 2 years ago (Migrated from gitlab.com)
Owner

Thanks!

Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
tablepad
textarea
wordwrap
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes