cview.Styles not being used #47

New Issue

tslocum · 2020-12-28T23:43:42Z

makeworld-the-better-one commented

2020-12-28 23:43:42 +00:00

(Migrated from gitlab.com)

When setting cview.Styles.PrimitiveBackgroundColor and then later calling NewTabbedPanels(), the background of that primitive (set in TabbedPanels.Switcher.Box) does not appear to use the value from cview.Styles. This also happens with SetTabSwitcherDivider.

In an unrelated instance, the ANSI conversion injects strings like [-:-:-] into the output, but this will reset the background to the terminal's background instead of the app's background. Either the ANSI conversion funcs should be changed, or setting the background to - should use cview.Styles.PrimitiveBackgroundColor instead of the terminal's background. I believe that latter makes more sense.

All these problems can be easily circumvented, through manual color setting or string replacment in the ANSI case, but it would be nice if cview handled it.

When setting `cview.Styles.PrimitiveBackgroundColor` and then later calling `NewTabbedPanels()`, the background of that primitive (set in `TabbedPanels.Switcher.Box`) does not appear to use the value from `cview.Styles`. This also happens with `SetTabSwitcherDivider`. In an unrelated instance, the ANSI conversion injects strings like `[-:-:-]` into the output, but this will reset the background to the terminal's background instead of the app's background. Either the ANSI conversion funcs should be changed, or setting the background to `-` should use `cview.Styles.PrimitiveBackgroundColor` instead of the terminal's background. I believe that latter makes more sense. All these problems can be easily circumvented, through manual color setting or string replacment in the ANSI case, but it would be nice if cview handled it.

tslocum added the

bug

label 2021-05-18 15:56:25 +00:00

tslocum referenced this issue from a commit

2021-05-25 19:45:40 +00:00

Fix resetting background color via '-'

tslocum closed this issue

2021-05-25 19:45:40 +00:00

tslocum commented

2021-05-25 19:46:16 +00:00

Thanks for reporting this.