Render images as images instead of links #4

Closed
opened 5 months ago by f · 2 comments
f commented 5 months ago

It would be nice if images are rendered as images instead of links. This should be easily done be adding some switch case here:

https://code.rocketnine.space/tslocum/gmitohtml/src/branch/master/pkg/gmitohtml/convert.go#L129-L134

Is there a reason not to do this?

It would be nice if images are rendered as images instead of links. This should be easily done be adding some switch case here: https://code.rocketnine.space/tslocum/gmitohtml/src/branch/master/pkg/gmitohtml/convert.go#L129-L134 Is there a reason not to do this?
f changed title from Render images as images to Render images as images instead of links 5 months ago
tslocum added the
enhancement
label 5 months ago
Owner

I think this would be a nice opt-in feature.

I think this would be a nice opt-in feature.
f commented 5 months ago
Poster

I created a PR for that. But I am not sure what exactly happened here: The binary (iamges) data will be put inside a HTML template. Maybe binary files are note supported yet? If I got some free time, I will dig into it.

I created a PR for that. But I am not sure what exactly happened here: The binary (iamges) data will be put inside a HTML template. Maybe binary files are note supported yet? If I got some free time, I will dig into it.
tslocum closed this issue 3 months ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.