Render images as images instead of links #4

Closed
opened 2021-06-03 20:32:30 +00:00 by f · 2 comments
Contributor

It would be nice if images are rendered as images instead of links. This should be easily done be adding some switch case here:

https://code.rocketnine.space/tslocum/gmitohtml/src/branch/master/pkg/gmitohtml/convert.go#L129-L134

Is there a reason not to do this?

It would be nice if images are rendered as images instead of links. This should be easily done be adding some switch case here: https://code.rocketnine.space/tslocum/gmitohtml/src/branch/master/pkg/gmitohtml/convert.go#L129-L134 Is there a reason not to do this?
f changed title from Render images as images to Render images as images instead of links 2021-06-03 20:32:39 +00:00
tslocum added the
enhancement
label 2021-06-04 01:19:53 +00:00
Owner

I think this would be a nice opt-in feature.

I think this would be a nice opt-in feature.
Author
Contributor

I created a PR for that. But I am not sure what exactly happened here: The binary (iamges) data will be put inside a HTML template. Maybe binary files are note supported yet? If I got some free time, I will dig into it.

I created a PR for that. But I am not sure what exactly happened here: The binary (iamges) data will be put inside a HTML template. Maybe binary files are note supported yet? If I got some free time, I will dig into it.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tslocum/gmitohtml#4
No description provided.