minor bug tinyib_hidefields #156

New Issue

tslocum · 2021-01-01T04:57:13Z

ghost1 commented

2021-01-01 04:57:13 +00:00

(Migrated from gitlab.com)

php 8.0 - flatfile mode

tinyib_hidefields is set to hide "file" in reply mode. No file button is shown in reply mode, however the text of of
"Images greater than 250x250 will be thumbnailed" still shows up under the form.
exact details -
$tinyib_hidefields = array('email', 'subject', 'file', 'embed', 'password');
edit--- Also of note, you might want to check the allow url's to be embedded, as this variable influences file posting, which should influence the "Images greater than 250x250 will be thumbnailed" part. >>>Suggested fix<<<- just make the "Images greater than 250x250 will be thumbnailed" part directly writable by the admin!!!! Like, if you just had about 3 text lines under the post form that could be edited in settings.php, the board op could then just set up the appropriate words for whatever state tinyib is in!!! This would make less code needed, you could delete some of the code, and you would not have to worry about what toggles what- because the text lines of info under the form are just directly influenced by settings.php --- that would be easier, way less bugs, it would prevent future bugs, and make it easier in the long run to code!!!!!!!

php 8.0 - flatfile mode tinyib_hidefields is set to hide "file" in reply mode. No file button is shown in reply mode, however the text of of "Images greater than 250x250 will be thumbnailed" still shows up under the form. exact details - $tinyib_hidefields = array('email', 'subject', 'file', 'embed', 'password');![ib](/uploads/44c9c9820c438d64c2086eaa0b0f5111/ib.jpg) edit--- Also of note, you might want to check the allow url's to be embedded, as this variable influences file posting, which should influence the "Images greater than 250x250 will be thumbnailed" part. >>>Suggested fix<<<- just make the "Images greater than 250x250 will be thumbnailed" part directly writable by the admin!!!! Like, if you just had about 3 text lines under the post form that could be edited in settings.php, the board op could then just set up the appropriate words for whatever state tinyib is in!!! This would make less code needed, you could delete some of the code, and you would not have to worry about what toggles what- because the text lines of info under the form are just directly influenced by settings.php --- that would be easier, way less bugs, it would prevent future bugs, and make it easier in the long run to code!!!!!!!

ghost1 commented

2021-01-01 04:58:27 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2021-01-01 05:08:50 +00:00

(Migrated from gitlab.com)

changed title from minor bug tinyib_hidefields{-op-} to minor bug tinyib_hidefields

changed title from **minor bug tinyib_hidefields{-op-}** to **minor bug tinyib_hidefields**

ghost1 commented

2021-01-01 05:08:50 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2021-01-01 05:12:38 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2021-01-01 06:01:50 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2021-01-01 06:02:35 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2021-01-01 06:03:11 +00:00

(Migrated from gitlab.com)

changed the description

tslocum commented

2021-01-06 01:20:57 +00:00

(Migrated from gitlab.com)

Thanks for suggesting this. Allowing the rule area to be modified would require adding a new database table, which is slightly involved to implement. Please add a thumbs up if you want to see this feature implemented, and consider donating to offset my time investment.

ghost1 commented

2021-01-06 09:06:20 +00:00

(Migrated from gitlab.com)

    $input_extra = '';
$rules_extra = '';

input extra and rules extra can just be written to directly in html.php, no database mods needed. You are right tho, anything that requires the db to be updated in all modes is NOT worth the effort and only complicates stuff! if I were you i would only work on removing code to make things easier instead of adding any more code. this is so tinyib can keep up with future php versions, --other boards that get too complicated can't keep up lol. ANY style change that can be just written manually by board ops into html.php could save on having to use db functions. Staying lean as possible makes tinyib more flexible to adapt with future php versions!!!!

$input_extra = ''; $rules_extra = ''; input extra and rules extra can just be written to directly in html.php, no database mods needed. You are right tho, anything that requires the db to be updated in all modes is NOT worth the effort and only complicates stuff! if I were you i would only work on removing code to make things easier instead of adding any more code. this is so tinyib can keep up with future php versions, --other boards that get too complicated can't keep up lol. ANY style change that can be just written manually by board ops into html.php could save on having to use db functions. Staying lean as possible makes tinyib more flexible to adapt with future php versions!!!!

tslocum added the

bug

label 2021-05-01 00:50:07 +00:00

tslocum removed the

bug

label 2021-05-01 02:52:30 +00:00

tslocum commented

2021-05-01 02:52:39 +00:00

This has since been resolved.

tslocum closed this issue

2021-05-01 02:52:39 +00:00

Sign in to join this conversation.