tslocum
/
tinyib
6
6
Fork 2
Code Issues 40 Pull Requests 1 Releases Activity
Labels Milestones

Fix audit log for flat file database #257

Merged
tslocum merged 1 commits from averageLukas/tinyib:fix/flatfile-audit-log into master 2 months ago
Conversation 3 Commits 1 Files Changed 1
averageLukas commented 2 months ago

PHP runs out of memory due to flat file's audit log implementation, and manage mode actions break.

Warning: Undefined array key 1 in /tmp/tinyib/inc/database/flatfile.php on line 207

Warning: Undefined array key 2 in /tmp/tinyib/inc/database/flatfile.php on line 208

Warning: Undefined array key 3 in /tmp/tinyib/inc/database/flatfile.php on line 209

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 65011720 bytes) in /tmp/tinyib/inc/database/flatfile/flatfile.php on line 344
PHP runs out of memory due to flat file's audit log implementation, and manage mode actions break. ``` Warning: Undefined array key 1 in /tmp/tinyib/inc/database/flatfile.php on line 207 Warning: Undefined array key 2 in /tmp/tinyib/inc/database/flatfile.php on line 208 Warning: Undefined array key 3 in /tmp/tinyib/inc/database/flatfile.php on line 209 Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 65011720 bytes) in /tmp/tinyib/inc/database/flatfile/flatfile.php on line 344 ```
averageLukas commented 2 months ago
Poster

Closes #245

Closes #245
tslocum commented 2 months ago
Owner

Nice catch. Please change $log['id'] to $log[LOG_ID], and then I will merge this. Thanks.

Nice catch. Please change `$log['id']` to `$log[LOG_ID]`, and then I will merge this. Thanks.
averageLukas force-pushed fix/flatfile-audit-log from 771677564b to f1e527e77e 2 months ago
averageLukas force-pushed fix/flatfile-audit-log from f1e527e77e to c5af7a0ef7 2 months ago
averageLukas commented 2 months ago
Poster

Done.

Done.
tslocum merged commit 648a4fe752 into master 2 months ago
averageLukas deleted branch fix/flatfile-audit-log 2 months ago
The pull request has been merged as 648a4fe752.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'averageLukas/tinyib:fix/flatfile-audit-log'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes