tslocum
/
tinyib
6
6
Fork 2
Code Issues 33 Pull Requests 1 Releases Activity

Labels Milestones

Fix audit log for flat file database #257

Merged
tslocum merged 1 commits from averageByte/tinyib:fix/flatfile-audit-log into master 9 months ago
Conversation 3 Commits 1 Files Changed 1
averageByte commented 9 months ago

PHP runs out of memory due to flat file's audit log implementation, and manage mode actions break.

Warning: Undefined array key 1 in /tmp/tinyib/inc/database/flatfile.php on line 207

Warning: Undefined array key 2 in /tmp/tinyib/inc/database/flatfile.php on line 208

Warning: Undefined array key 3 in /tmp/tinyib/inc/database/flatfile.php on line 209

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 65011720 bytes) in /tmp/tinyib/inc/database/flatfile/flatfile.php on line 344
PHP runs out of memory due to flat file's audit log implementation, and manage mode actions break. ``` Warning: Undefined array key 1 in /tmp/tinyib/inc/database/flatfile.php on line 207 Warning: Undefined array key 2 in /tmp/tinyib/inc/database/flatfile.php on line 208 Warning: Undefined array key 3 in /tmp/tinyib/inc/database/flatfile.php on line 209 Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 65011720 bytes) in /tmp/tinyib/inc/database/flatfile/flatfile.php on line 344 ```
averageByte commented 9 months ago
Poster

Closes #245

Closes #245
tslocum commented 9 months ago
Owner

Nice catch. Please change $log['id'] to $log[LOG_ID], and then I will merge this. Thanks.

Nice catch. Please change `$log['id']` to `$log[LOG_ID]`, and then I will merge this. Thanks.
averageByte commented 9 months ago
Poster

Done.

Done.
tslocum merged commit 648a4fe752 into master 9 months ago
averageByte deleted branch fix/flatfile-audit-log 9 months ago
The pull request has been merged as 648a4fe752.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b averageByte-fix/flatfile-audit-log master
git pull fix/flatfile-audit-log

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff averageByte-fix/flatfile-audit-log
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tslocum/tinyib#257
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'averageByte/tinyib:fix/flatfile-audit-log'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes