WIP: Add AVIF support #258

Open
averageLukas wants to merge 1 commits from averageLukas/tinyib:feature/avif-support into master

Closes #210

I didn't test whether the deprecation warning fix breaks TinyIB for PHP 5.5

Closes #210 I didn't test whether the deprecation warning fix breaks TinyIB for PHP 5.5
Poster

On second thought, the deprecation warning fix won't break TinyIB for PHP 5.5 since the current code base uses the new variable syntax already, see this code piece for reference.

On second thought, the deprecation warning fix won't break TinyIB for PHP 5.5 since the current code base uses the new variable syntax already, see [this code piece](https://code.rocketnine.space/tslocum/tinyib/src/commit/735ad801ab1817f9564a24b4841262ea9409e85d/inc/html.php#L501) for reference.
Owner

Thanks for submitting this. I will review and merge ASAP. Frustrating that PHP not only changed the variable parsing syntax but removed the "old" way entirely. Oh well.

Thanks for submitting this. I will review and merge ASAP. Frustrating that PHP not only changed the variable parsing syntax but removed the "old" way entirely. Oh well.
Poster

I forgot to add fallback images. 😆 I should've read #210 before writing this.

I forgot to add fallback images. 😆 I should've read #210 before writing this.
averageLukas changed title from Add AVIF support to WIP: Add AVIF support 2 months ago
averageLukas force-pushed feature/avif-support from 495e3db40c to 024938aab9 2 months ago
averageLukas force-pushed feature/avif-support from 024938aab9 to bf27c144ba 2 months ago
averageLukas force-pushed feature/avif-support from bf27c144ba to 8d627b928d 2 months ago
Poster

Fallback images exist now. I'll sleep over it, refactor my code and the encompassing scope. And see what I missed.

Should I revert my cosmetic createThumbnail changes? I'm too tired rn to untagle my slip-up here, but maybe tomorrow or so.

Also, is there some sort of code style? I feel like the use of single and double quotes is kinda random. Or maybe I'm too tired to see the big picture, I dunno.

Fallback images exist now. I'll sleep over it, refactor my code and the encompassing scope. And see what I missed. Should I revert my cosmetic `createThumbnail` changes? I'm too tired rn to untagle my slip-up here, but maybe tomorrow or so. Also, is there some sort of code style? I feel like the use of single and double quotes is kinda random. Or maybe I'm too tired to see the big picture, I dunno.
Owner

Thanks again for submitting this. I've looked over your changes more closely and there seem to be a lot of changes beyond adding AVIF support. It would be helpful if you could update this PR to only contain the changes necessary to add AVIF support. If you would like to submit additional changes to TinyIB, please submit them as additional separate PRs.

Thanks again for submitting this. I've looked over your changes more closely and there seem to be a lot of changes beyond adding AVIF support. It would be helpful if you could update this PR to only contain the changes necessary to add AVIF support. If you would like to submit additional changes to TinyIB, please submit them as additional separate PRs.
Poster

I've looked over your changes more closely and there seem to be a lot of changes beyond adding AVIF support.

What changes are you referring to? Besides the refactored image processing code in inc/functions.php.

> I've looked over your changes more closely and there seem to be a lot of changes beyond adding AVIF support. What changes are you referring to? Besides the refactored image processing code in `inc/functions.php`.
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.